improve the confused assert message #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

stleary merged 2 commits into stleary:master from Alanscut:bean-test

Dec 30, 2019

Contributor

Alanscut commented Dec 28, 2019

The test cases for bean parse are good, but some assert messages make people coufused, some fields are found but described as not working, while another fields are not found but described as found.


          improve the confused assert message

16da56e

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

stleary reviewed

View reviewed changes

src/test/java/org/json/junit/JSONObjectTest.java Outdated Show resolved Hide resolved

Owner

stleary commented Dec 29, 2019

@Alanscut thanks for helping improve the unit tests. I think some of your assert messages may still be off, have commented same. Let me know if you disagree.
These asserts are very confusing, adding comments and clear assert messages helps everyone to understand them better.


          Apply suggestions from code review

08719d4

Co-Authored-By: Sean Leary <[email protected]>

Contributor Author

Alanscut commented Dec 30, 2019

@stleary Thanks your suggestion! It make the assert messages more clear 👍

stleary merged commit f07ddd9 into stleary:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet